198 make dark mode work #277
Merged
+306
−272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckground that I need to fix
…ckground that I need to fix
…ll debating between having the text be coral or white. Is functional
…ault preference back to light mode.
…utton, and scout. Fixed some bugs as well
Ryan-Bauroth
requested changes
Jan 17, 2025
There was a problem hiding this comment.
This looks great! This ended up being a lot harder of a task than I originally thought, and you have killed it. There are a couple places I think some cleanup could be helpful, but this is basically perfect.
If you want to clean these up:
- The username when on the settings icon is black on black
- The /teams/[id].vue page has some issues with font and graph colors
These next two are more preference, no need to change if you don't want:
- Maybe change the yellow of the notes button on the matches.vue page
- Changing the predict.vue red and blue colors to a different shade for darc mode might look better
# Conflicts: # pages/attachment/add.vue # pages/dashboard.vue # pages/notes.vue # pages/predict.vue # pages/teams/[id].vue # pages/teams/attachments/[id].vue # pages/teams/index.vue
Ryan-Bauroth
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Looks good. I fixed a few bugs and merged the current state of the testing branch into this branch to allow for an easier PR. I also tweaked some colors around to try to make things more clear, but you are welcome to go through and undo any of those tweaks if you disagree.
|
@Megarolo all good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dark mode no longer sucks.